Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve treeTable implementation for accessibility #3320

Merged
merged 9 commits into from
Dec 1, 2022
Merged

Improve treeTable implementation for accessibility #3320

merged 9 commits into from
Dec 1, 2022

Conversation

bahadirsofuoglu
Copy link
Contributor

@bahadirsofuoglu bahadirsofuoglu commented Nov 22, 2022 •
edited
Loading

Completed #3319

@github-actions github-actions bot added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Nov 22, 2022
tugcekucukoglu
tugcekucukoglu reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@tugcekucukoglu tugcekucukoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • in sortable mode space key does not sort
  • in sortable mode: if there is a selected row, that row should have tabindex 1 and other unselected rows should have tabindex: 0 (current case: only first row have tabindex:0 )

@tugcekucukoglu
Copy link
Member

tugcekucukoglu commented Nov 25, 2022 •
edited
Loading

  • role table, rowgroup, columnheader and tableProps are missing.
  • when a row is selected, the row has no p-highlight class.
  • selected row should have aria-selected attribute

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 25, 2022
@github-actions github-actions bot removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 25, 2022
@tugcekucukoglu tugcekucukoglu merged commit d0032db into master Dec 1, 2022
@tugcekucukoglu tugcekucukoglu deleted the issue-3319 branch December 1, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tugcekucukoglu tugcekucukoglu Awaiting requested review from tugcekucukoglu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bahadirsofuoglu @tugcekucukoglu