Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DataView implementation for accessibility #3311

Merged
merged 6 commits into from
Nov 24, 2022
Merged

Conversation

bahadirsofuoglu
Copy link
Contributor

completed #3310

@github-actions
Copy link

Thanks a lot for your contribution! But, Unit tests failed. You can check the unit tests with the command 'npm run test:unit' and commit the changes.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 20, 2022
@github-actions github-actions bot removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 20, 2022
@github-actions
Copy link

Thanks a lot for your contribution! But, Unit tests failed. You can check the unit tests with the command 'npm run test:unit' and commit the changes.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 24, 2022
Copy link
Member

@tugcekucukoglu tugcekucukoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • group role not added
  • buttons should have the aria-label, not the container element
  • documentation should be fixed

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@github-actions github-actions bot removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 24, 2022
@tugcekucukoglu tugcekucukoglu merged commit fe48554 into master Nov 24, 2022
@tugcekucukoglu tugcekucukoglu deleted the issue-3310 branch November 24, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants