set readonly prop to readonly attribute #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tugcekucukoglu
added
the
Status: Pending Review
tugcekucukoglu
removed
the
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
When submitting a PR, please also create an issue documenting the error.
In Calendar component,
readonlyprop is not working as expected sincemanualInputprop is set to readonly attribute instead.Currently, when
readonlyprop is set true, input still accepts new input.The issue is described here #125
The repo for readonly bug is here https://github.com/nagisaando/primevue-calendar-readonly-error