Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: Chinese IME input will be stopped in filter input element #6279

Closed
charlie0228 opened this issue Aug 23, 2024 · 1 comment · Fixed by #6280
Closed

Select: Chinese IME input will be stopped in filter input element #6279

charlie0228 opened this issue Aug 23, 2024 · 1 comment · Fixed by #6280
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@charlie0228
Copy link
Contributor

Describe the bug

When using Chinese, Japanese or Korean IME, when typing and select characters.
It will accident trigger unexpected behavior in <Select> filter input and break up typing process.

Just like the GIF below, when I'm typing & using Enter to confirm the typing, the <Select> filter will trigger keydown Enter to close the dropdown panel.
And the Selected Item is not changed.

Aug-23-2024 17-13-37

Reproducer

https://stackblitz.com/edit/primevue-4-ts-vite-issue-template-a9rucv?file=src%2FApp.vue

PrimeVue version

4.0.4

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Using Chinese, Japanese or Korean IME to typing in <Select> filter input.

Expected behavior

Avoid filter keydown detect when IME is composing.

@charlie0228 charlie0228 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 23, 2024
@hurahurat
Copy link

Not only Select component but AutoComplete with chip.
When enter is press please detect when IME is composing.
ie. if (event.isComposing || event.keyCode === 229) return;

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 10, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.7 milestone Sep 10, 2024
tugcekucukoglu added a commit that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants