Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonGroup: Missing buttongroup in PrimeVuePTOptions #6137

Closed
phamhongphuc opened this issue Jul 29, 2024 · 0 comments · Fixed by #6146
Closed

ButtonGroup: Missing buttongroup in PrimeVuePTOptions #6137

phamhongphuc opened this issue Jul 29, 2024 · 0 comments · Fixed by #6146
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@phamhongphuc
Copy link

phamhongphuc commented Jul 29, 2024

Describe the bug

https://github.com/primefaces/primevue/blob/4.0.2/packages/primevue/src/config/Config.d.ts

image

import { createApp } from 'vue';
import PrimeVue, { PrimeVueConfiguration, PrimeVuePTOptions } from 'primevue/config';
import App from './App.vue';

const app = createApp(App);

export const presets: PrimeVuePTOptions = {
  button: {
    root: {
      class: 'custom-button',
    },
  },
  buttongroup: {
    root: {
      class: 'custom-button-group',
    },
  },
};

const config: PrimeVueConfiguration = {
  pt: presets,
  theme: {
    preset: Aura,
  },
};

app.use(PrimeVue, config);

Reproducer

https://stackblitz.com/edit/culur-primevue-4-ts-vite-issue-typescript?file=src%2Fmain.ts

PrimeVue version

4.0.2

Vue version

4.x

Language

TypeScript

Build / Runtime

TypeScript

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@phamhongphuc phamhongphuc added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 29, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.1.0 milestone Jul 29, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 29, 2024
avramz added a commit to avramz/primevue that referenced this issue Jul 30, 2024
@tugcekucukoglu tugcekucukoglu modified the milestones: 4.1.0, 4.0.4 Jul 31, 2024
tugcekucukoglu added a commit that referenced this issue Jul 31, 2024
Fix - add buttongroup to PrimeVuePTOptions #6137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants