Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu componets: Design Token does not work #6129

Closed
ShiYaoDiving opened this issue Jul 27, 2024 · 13 comments
Closed

Menu componets: Design Token does not work #6129

ShiYaoDiving opened this issue Jul 27, 2024 · 13 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ShiYaoDiving
Copy link

Describe the bug

Design token do not work on MENU, these is no 'PC{id}' in the

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-fhzqdg?file=src%2FApp.vue

PrimeVue version

4.0.1

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Just like the case demonstrating.

does not work

Expected behavior

I think there must be some code missing....

@ShiYaoDiving ShiYaoDiving added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 27, 2024
@leosin
Copy link

leosin commented Jul 30, 2024

The same situation also has: popover, menu

@ShiYaoDiving
Copy link
Author

I think it is because of the of Menu.vue.
If I remove the

<Portal :appendTo="appendTo" :disabled="!popup">

(line2 in Menu.vue).
The Design Token will work

@ShiYaoDiving
Copy link
Author

I think it because of the Portal is outside of the div.. it iwll influence all components with that:
autocomplete.calendar,,cascadeselect colorpicker contextmenu dialog dropdown menu multiselect overlaypanel....

@cromerc
Copy link

cromerc commented Aug 7, 2024

Running into the same problem here. Something of note, the problem only occurs when using a scoped design token. I can set the style using design tokens in my global component preset theme. However that isn't what I want to do, I want to use a scoped token to only style a specific menu and not all of them.

This is only primevue 4.0.4.

@ShiYaoDiving
Copy link
Author

That’s right and i think it just because of the If you remove them from Menu.vue and the dt will work

@micvm
Copy link

micvm commented Aug 8, 2024

Is this the same matter also for the Dialog component?

https://stackblitz.com/edit/cnrvm8?file=src%2FApp.vue

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 23, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.6 milestone Aug 23, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 23, 2024
@tugcekucukoglu
Copy link
Member

Thanks for the reports. It'll be fixed for version 4.0.6.

@oliver139
Copy link

Oh this is a bug..
I thought I was doing something wrong

@tugcekucukoglu tugcekucukoglu modified the milestones: 4.0.6, 4.0.7 Sep 10, 2024
@tugcekucukoglu tugcekucukoglu changed the title Menu:Design Token does not work Menu componets: Design Token does not work Sep 10, 2024
@tugcekucukoglu tugcekucukoglu modified the milestones: 4.0.7, 4.1.0 Sep 11, 2024
@jbsaltship
Copy link

@tugcekucukoglu Tooltip still doesn't react on changes of Design Tokens property.

@svwezel
Copy link

svwezel commented Sep 19, 2024

Button and Tabs Also don't seem to work.

@2234839
Copy link
Contributor

2234839 commented Sep 20, 2024

The select component is valid here before, but it is not valid today

@tugcekucukoglu
Copy link
Member

Thanks for the stackblitz examples. We are investigating the issue, which will be fixed for the next version 4.1.0.

@deisner
Copy link

deisner commented Oct 1, 2024

Button and Tabs Also don't seem to work.

@svwezel Could be #6129. If you roll-back to Vue 3.5.5, does it work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

10 participants