Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion: Theming content background not working #5997

Closed
Willen17 opened this issue Jul 1, 2024 · 2 comments · Fixed by #6032
Closed

Accordion: Theming content background not working #5997

Willen17 opened this issue Jul 1, 2024 · 2 comments · Fixed by #6032
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Willen17
Copy link

Willen17 commented Jul 1, 2024

Describe the bug

components/lib/accordion/style/AccordionStyle.js

Changing background for the content in the accordion does not work. There is a mistake present in the code, ther should not be a color: property after background:

.p-accordioncontent-content { /../ background: color: ${dt('accordion.content.background')}; /../ }

it should be:

.p-accordioncontent-content { /../ background: ${dt('accordion.content.background')}; /../ }

Reproducer

PrimeVue version

4.0.0-rc.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

Check the applied background styling for Accordion-content-content.

Expected behavior

No response

@Willen17 Willen17 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 1, 2024
@eneeio-nm
Copy link
Contributor

I can confirm this via Devtools:

screenshot-2024-07-09--09 18 02@2x

@eneeio-nm
Copy link
Contributor

@Willen17 I believe it should actually be .p-accordioncontent-content { /../ background-color: ${dt('accordion.content.background')}; /../ }

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 9, 2024
@mertsincan mertsincan added this to the 4.0.1 milestone Jul 9, 2024
mertsincan pushed a commit that referenced this issue Jul 9, 2024
…#6032)

* fix for #5997

This is a fix for #5997

* Update packages/primevue/src/accordion/style/AccordionStyle.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants