Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: Ripple Position #5690

Closed
Rojta opened this issue May 5, 2024 · 0 comments
Closed

Tabs: Ripple Position #5690

Rojta opened this issue May 5, 2024 · 0 comments
Assignees
@mertsincan
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.0-beta.3

Comments

@Rojta
Copy link

Rojta commented May 5, 2024

Describe the bug

The tabs component ripple effect is not the right size and position. Same problem on the docs website and my local project.

Reproducer

https://v4.primevue.org/tabs/#basic

PrimeVue version

4.0.0-beta.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://v4.primevue.org/tabs/#basic
  2. Enable ripple effect, and dark mode (the easier to see the ripple), and change tabs.
  3. See that the ripple size is too big and the position is not at the right spot.

Expected behavior

It should be like the v3 Tabview when ripple is enabled.
@Rojta Rojta added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 5, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 8, 2024
@mertsincan mertsincan self-assigned this May 8, 2024
@mertsincan mertsincan added this to the 4.0.0-beta.3 milestone May 8, 2024
mertsincan added a commit that referenced this issue May 8, 2024
@mertsincan
Fixed #5690 - Tabs: Ripple Position
0d243aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.0-beta.3
Development

No branches or pull requests
2 participants
@mertsincan @Rojta