Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Hours are set to 00 when clicking the "Today" button #5596

Closed
thristov78 opened this issue Apr 16, 2024 · 1 comment · Fixed by DallinAllred/ezanalytics#11 · May be fixed by jennytoc/mfe-proj#2
Closed

Calendar: Hours are set to 00 when clicking the "Today" button #5596

thristov78 opened this issue Apr 16, 2024 · 1 comment · Fixed by DallinAllred/ezanalytics#11 · May be fixed by jennytoc/mfe-proj#2
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@thristov78
Copy link
Contributor

thristov78 commented Apr 16, 2024 •
edited
Loading

Describe the bug

When the "Today" button is clicked, the hours field is set to 00 instead of the current hour. The minutes field is populated correctly.

The problem can be reproduced with showTime and showButtonBar attributes enable.

Reproducer

https://stackblitz.com/edit/primevue-calendar-today-hours-bug?file=src%2FApp.vue

PrimeVue version

3.51.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://stackblitz.com/edit/primevue-calendar-today-hours-bug?file=src%2FApp.vue
  2. Click on the calendar component
  3. The calendar displays the current date, hours, minutes
  4. Click on the "Today" button
  5. The hours field is changes to 00, not to the current hour

Expected behavior

The hours field should be populated with the current hour, just like the minutes fields.
@thristov78 thristov78 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 16, 2024
@srabieb
Copy link

srabieb commented Apr 17, 2024 •
edited
Loading

i have the same problem

tugcekucukoglu added a commit that referenced this issue Apr 19, 2024
@tugcekucukoglu
Merge pull request #5607 from thristov78/patch-1
dd71f32 
Fixed #5596 - Calendar: Hours are set to 00 when clicking the "Today" button
m-meier added a commit to m-meier/primevue that referenced this issue May 8, 2024
@m-meier
fix(DatePicker): set hour on 24h mode on date select, fixes primeface…
7f7b909 
…s#5596

This commit is a copy of PR primefaces#5607 for the v4 branch. Since the component was renamed, the fix from the master branch was not applied to the new component.
@m-meier m-meier mentioned this issue May 8, 2024
Merged
tugcekucukoglu added a commit that referenced this issue May 16, 2024
@tugcekucukoglu
Merge pull request #5702 from m-meier/patch-4
57de63f 
fix(DatePicker): set hour on 24h mode on date select, fixes #5596
@Thiritin Thiritin mentioned this issue May 17, 2024
Closed
@DallinAllred DallinAllred mentioned this issue Jun 22, 2024
Merged
@jennytoc jennytoc mentioned this issue Jun 28, 2024
Open
@gn00029914 gn00029914 mentioned this issue Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
2 participants
@thristov78 @srabieb