Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber Not Working android #5545

Closed
hiepeng opened this issue Apr 7, 2024 · 3 comments
Closed

InputNumber Not Working android #5545

hiepeng opened this issue Apr 7, 2024 · 3 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.52.0

Comments

@hiepeng
Copy link

hiepeng commented Apr 7, 2024

Describe the bug

Screenrecorder-2024-04-07-13-37-11-209.mp4

Reproducer

https://stackblitz.com/edit/primevue-create-vue-issue-template?file=README.md

PrimeVue version

3.49.1

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

browse android

Steps to reproduce the behavior

help

Expected behavior

help
@hiepeng hiepeng added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 7, 2024
@melloware
Copy link
Member

melloware commented Apr 7, 2024 •
edited
Loading

You can read about it here on PrimeReact: primefaces/primereact#6275

I explain exactly why it is not working. Basically PrimeTek has properly removed onKeyPress events which is deprecated in all browsers. The bad news is of course Android is the ONLY browser that doesn't respect proper keyboard events. So hacks will have to be made to support android. cc @FlipWarthog

@melloware
Copy link
Member

See Primereact PR: primefaces/primereact#6332

dispatchrabbi added a commit to dispatchrabbi/primevue that referenced this issue Apr 22, 2024
@dispatchrabbi
Fixed primefaces#5545: Restore functionality for InputNumber on Android
78f0d5e
dispatchrabbi added a commit to dispatchrabbi/primevue that referenced this issue Apr 22, 2024
@dispatchrabbi
Fixed primefaces#5545: Restore functionality for InputNumber on Android
b554052
@dispatchrabbi dispatchrabbi mentioned this issue Apr 22, 2024
Closed
@cagataycivici cagataycivici added this to the 3.52.0 milestone Apr 23, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 24, 2024
@tugcekucukoglu
Copy link
Member

Thanks for the clarification. It was reverted for the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.52.0
Development

Successfully merging a pull request may close this issue.

Fixed #5545: Restore functionality for InputNumber on Android dispatchrabbi/primevue
4 participants
@cagataycivici @melloware @tugcekucukoglu @hiepeng