Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton: some preventDefault are missing #4223

Closed
FVolral opened this issue Jul 31, 2023 · 1 comment · Fixed by #4224
Closed

SplitButton: some preventDefault are missing #4223

FVolral opened this issue Jul 31, 2023 · 1 comment · Fixed by #4224
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.34.1

Comments

@FVolral
Copy link

FVolral commented Jul 31, 2023

Describe the bug

The SplitButton component of PrimeVue is missing some preventDefault()

Reproducer

https://codesandbox.io/p/sandbox/exciting-pateu-l9t63h?file=%2Fsrc%2FApp.vue%3A49%2C73

PrimeVue version

3.31.0

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Click on the dropdown button

Expected behavior

I expect the event not to be propagated using event.preventDefault
@FVolral FVolral added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 31, 2023
@FVolral FVolral changed the title SplitButton: a preventDefault is missing when clicking on the dropdown button SplitButton: some preventDefault are missing Jul 31, 2023
FVolral pushed a commit to FVolral/primevue that referenced this issue Jul 31, 2023
Fix: Add preventDefault on SplitButton click event
8ef9848 
The SplitButton component of PrimeVue was missing a preventDefault()
call when clicking on the button that opens the dropdown menu. This
caused unexpected behavior when interacting with the dropdown menu.
The issue has been resolved by adding the preventDefault() on the click
event, ensuring smooth and expected functionality.

Fixes primefaces#4223"
@FVolral FVolral mentioned this issue Jul 31, 2023
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 8, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.34.1 milestone Sep 8, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Sep 8, 2023
tugcekucukoglu added a commit that referenced this issue Sep 8, 2023
@tugcekucukoglu
Refactor #4223
10d1fd9
@FVolral
Copy link
Author

FVolral commented Sep 25, 2023

In fact, it's more a event.stopPropagation() which is missing, preventDefault() doesn't fix my problem

@FVolral FVolral mentioned this issue Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.34.1
2 participants
@tugcekucukoglu @FVolral