Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Preview not closing on escape click #4089

Closed
mneciunas opened this issue Jun 27, 2023 · 0 comments · Fixed by #4098
Closed

Image: Preview not closing on escape click #4089

mneciunas opened this issue Jun 27, 2023 · 0 comments · Fixed by #4098
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.31.0

Comments

@mneciunas
Copy link

Describe the bug

Trying to close image preview with escape button results in exception:
TypeError: Cannot read properties of undefined (reading 'target')

Seems like this bug has been introduce with this commit: 5f57291
when an event parameter has been added to onMaskClick() method, while onMaskKeydown() method uses onMaskClick() method inside without passing any parameters

Reproducer

https://primevue.org/image/

PrimeVue version

3.29.2

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Currently can be reproduced in PrimeVue docs
https://primevue.org/image/

  1. Open Image preview
  2. Press escape on keyboard

Expected behavior

No response
@mneciunas mneciunas added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 27, 2023
@mneciunas mneciunas changed the title Image Component: Preview not closing on escape click Image: Preview not closing on escape click Jun 27, 2023
This was referenced Jul 1, 2023
Merged
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 21, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.30.3 milestone Jul 21, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 21, 2023
tugcekucukoglu added a commit that referenced this issue Jul 21, 2023
@tugcekucukoglu
Refactor #4089 - Image accessibility update
8a7b069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.31.0
Development

Successfully merging a pull request may close this issue.

fix: fix image preview not closing on escape qburst/primevue-1
2 participants
@mneciunas @tugcekucukoglu