Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb: SSR Error window is not defined #3156

Closed
jf908 opened this issue Oct 25, 2022 · 0 comments · Fixed by #3165
Closed

Breadcrumb: SSR Error window is not defined #3156

jf908 opened this issue Oct 25, 2022 · 0 comments · Fixed by #3165
Assignees
@bahadirsofuoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.18.1

Comments

@jf908
Copy link

jf908 commented Oct 25, 2022

Describe the bug

The Breadcrumb component errors in SSR mode because of this use of window.

primevue/src/components/breadcrumb/BreadcrumbItem.vue

Line 63 in 6eaabd8

const lastPath = `/${window.location.href.split('/').pop()}`;

Reproducer

No response

PrimeVue version

3.18.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

Try to SSR render <Breadcrumb> in a Nuxt app.

Expected behavior

No response
@jf908 jf908 added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 25, 2022
@bahadirsofuoglu bahadirsofuoglu self-assigned this Oct 26, 2022
@bahadirsofuoglu bahadirsofuoglu added this to the 3.18.1 milestone Oct 26, 2022
bahadirsofuoglu added a commit that referenced this issue Oct 26, 2022
@bahadirsofuoglu
Fixed #3156 - Window removed from breadcrumb component
58b0856
@bahadirsofuoglu bahadirsofuoglu mentioned this issue Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahadirsofuoglu bahadirsofuoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.18.1
Development

Successfully merging a pull request may close this issue.

Window removed from breadcrumb component primefaces/primevue
2 participants
@jf908 @bahadirsofuoglu