Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelMenu keyboard navigation #2181

Closed
MrMcBossman opened this issue Feb 17, 2022 · 0 comments · Fixed by #2182
Closed

PanelMenu keyboard navigation #2181

MrMcBossman opened this issue Feb 17, 2022 · 0 comments · Fixed by #2182
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@MrMcBossman
Copy link

If you have a PrimeVue PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 1 business hour.

If you do not have a PrimeVue PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~1-4 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

CodeSandbox Case (Bug Reports)
Please demonstrate your case at CodeSandbox by using the issue template below. Issues without a test case have much less possibility to be reviewed in detail and assisted.

https://primefaces.org/primevue/showcase/#/panelmenu

Current behavior
PanelMenu items cannot be opened with the keyboard by tabbing over one and hitting enter on the keyboard. They do highlight but won't open their items when hitting enter. The PanelMenu items have an attribute of tabindex="0" meaning they should be able to be interacted with via the keyboard. This is a 508 issue because only active elements should be in the tab order. The ARC Toolkit recommends: Remove the tabindex attribute or set it to '-1', OR define the role of the control.

Expected behavior
Should "click" the panelmenu item when focused on panelmenu item and enter key is hit.

Minimal reproduction of the problem with instructions
->navigate to https://primefaces.org/primevue/showcase/#/panelmenu
->tab over a panelmenu item and hit enter key
->nothing happens

What is the motivation / use case for changing the behavior?
508 compliance of Primevue components

Please tell us about your environment:
Centos 7
Chrome browser

  • Vue version: 3.X
    Vue 3.2.19

  • PrimeVue version: 3.4.X
    3.10

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Only tried in chrome

primevue panelmenu Discord Discussion

FlipWarthog added a commit to FlipWarthog/primevue that referenced this issue Feb 17, 2022
@tugcekucukoglu tugcekucukoglu changed the title PanelMenu 508 compliance issue PanelMenu keyboard navigation Feb 18, 2022
@tugcekucukoglu tugcekucukoglu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Feb 18, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.12.1 milestone Feb 18, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants