Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TypeScript Definitions on all components #1836

Closed
mertsincan opened this issue Dec 1, 2021 · 4 comments
Closed

Improve TypeScript Definitions on all components #1836

mertsincan opened this issue Dec 1, 2021 · 4 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mertsincan
Copy link
Member

All definitions have been rewritten so that users can use the components more easily.

@mertsincan mertsincan self-assigned this Dec 1, 2021
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Dec 1, 2021
@mertsincan mertsincan added this to the 3.10.0 milestone Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
mertsincan added a commit that referenced this issue Dec 1, 2021
@ReevMich
Copy link
Contributor

ReevMich commented Dec 8, 2021

There seems to be a missing property for ConfirmationOptions.d.tsinterface. Its missing header: string. @mertsincan, do you want me to open an issue for this?

@mertsincan
Copy link
Member Author

Hi @ReevMich,

Of course! Also, you can create a PR ;)

@awulkan
Copy link

awulkan commented Dec 8, 2021

We're having some problems with DataTable filters after this update. Everything still works, but TypeScript is throwing errors. We're trying to figure it out, but if not, we'll create an issue.

The problem we're facing appears caused by this line: 9a9ae86#diff-37a8b4c9777d570bdbd9165b983cfaa3a208dd286f8ea9ae8e28e1f3a50f888bR77

TypeScript says that there is no .value on our filters['global'].value in our template code. Since it thinks our filter is of the type DataTableOperatorFilterMetaData.


Update: We were able to get through it by defining the type of each filter, but NOT set a type on the filter itself.

const filters = reactive({
  global: {
    value: '',
    matchMode: FilterMatchMode.CONTAINS,
  } as DataTableFilterMetaData,
  name: {
    operator: FilterOperator.AND,
    constraints: [{
      value: '',
      matchMode: FilterMatchMode.STARTS_WITH,
    }],
  } as DataTableOperatorFilterMetaData,
    aliases: {
    operator: FilterOperator.AND,
    constraints: [{
      value: '',
      matchMode: 'aliasFilter',
    }],
  } as unknown as DataTableOperatorFilterMetaData, // Had to convert to unknown first to make our custom filter work.
});

@cm-santos
Copy link

TabPanel header slot definition seems to be missing.

`TS7053: Element implicitly has an 'any' type because expression of type '"header"' can't be used to index type '{ default: unknown; }'.
Property 'header' does not exist on type '{ default: unknown; }'.

58 <template #header>`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants