-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TypeScript Definitions on all components #1836
Comments
There seems to be a missing property for |
Hi @ReevMich, Of course! Also, you can create a PR ;) |
We're having some problems with DataTable filters after this update. Everything still works, but TypeScript is throwing errors. We're trying to figure it out, but if not, we'll create an issue. The problem we're facing appears caused by this line: 9a9ae86#diff-37a8b4c9777d570bdbd9165b983cfaa3a208dd286f8ea9ae8e28e1f3a50f888bR77 TypeScript says that there is no Update: We were able to get through it by defining the type of each filter, but NOT set a type on the filter itself. const filters = reactive({
global: {
value: '',
matchMode: FilterMatchMode.CONTAINS,
} as DataTableFilterMetaData,
name: {
operator: FilterOperator.AND,
constraints: [{
value: '',
matchMode: FilterMatchMode.STARTS_WITH,
}],
} as DataTableOperatorFilterMetaData,
aliases: {
operator: FilterOperator.AND,
constraints: [{
value: '',
matchMode: 'aliasFilter',
}],
} as unknown as DataTableOperatorFilterMetaData, // Had to convert to unknown first to make our custom filter work.
}); |
TabPanel header slot definition seems to be missing. `TS7053: Element implicitly has an 'any' type because expression of type '"header"' can't be used to index type '{ default: unknown; }'. 58 <template #header>` |
All definitions have been rewritten so that users can use the components more easily.
The text was updated successfully, but these errors were encountered: