Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable - The showClearButton literally doesn't do anything #1532

Closed
JohnCampionJr opened this issue Sep 10, 2021 · 0 comments · Fixed by #1533
Closed

DataTable - The showClearButton literally doesn't do anything #1532

JohnCampionJr opened this issue Sep 10, 2021 · 0 comments · Fixed by #1533
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.7.2

Comments

@JohnCampionJr
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

Current behavior
The showClearButton property on datatable does nothing. Its documented, and a review of the code shows the prop going down to the ColumnFilter component, but it's never used.

Expected behavior
The clear button should reflect that property

  • Vue version: 3.2

  • PrimeVue version: 3.7.1

  • Browser: all

PR Coming
@JohnCampionJr JohnCampionJr mentioned this issue Sep 10, 2021
Merged
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 14, 2021
@mertsincan mertsincan added this to the 3.7.2 milestone Sep 14, 2021
mertsincan pushed a commit that referenced this issue Sep 14, 2021
@JohnCampionJr
[Fix #1532] DataTable - Implements showClearButton property (#1533)
0298dde 
Closes #1532.
mertsincan added a commit that referenced this issue Sep 14, 2021
@mertsincan
Refactor #1532
aee227f
@yigitfindikli yigitfindikli mentioned this issue Sep 21, 2021
Closed
@nclemeur nclemeur mentioned this issue Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.7.2
Development

Successfully merging a pull request may close this issue.

[Fix #1532] DataTable - Implements showClearButton property
3 participants
@cagataycivici @JohnCampionJr @mertsincan