Merge pull request #5128 from primefaces/issue-5046

Icon id hydration
primefaces · Jan 23, 2024 · f0880cd · f0880cd
2 parents 537671f + 6ccebe1
commit f0880cd
Show file tree

Hide file tree

Showing 28 changed files with 33 additions and 190 deletions.
diff --git a/components/lib/baseicon/BaseIcon.vue b/components/lib/baseicon/BaseIcon.vue
@@ -1,7 +1,7 @@
 <script>
 import BaseComponent from 'primevue/basecomponent';
 import BaseIconStyle from 'primevue/baseicon/style';
-import { ObjectUtils } from 'primevue/utils';
+import { ObjectUtils, UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'BaseIcon',
@@ -17,6 +17,11 @@ export default {
         }
     },
     style: BaseIconStyle,
+    computed: {
+        pathId() {
+            return UniqueComponentId('pv_icon_clip_pv_id_');
+        }
+    },
     methods: {
         pti() {
             const isLabelEmpty = ObjectUtils.isEmpty(this.label);

diff --git a/components/lib/icons/arrowdown/index.vue b/components/lib/icons/arrowdown/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'ArrowDownIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/arrowup/index.vue b/components/lib/icons/arrowup/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'ArrowUpIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/ban/index.vue b/components/lib/icons/ban/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'BanIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/exclamationtriangle/index.vue b/components/lib/icons/exclamationtriangle/index.vue
@@ -24,15 +24,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'ExclamationTriangleIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/eyeslash/index.vue b/components/lib/icons/eyeslash/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'EyeSlashIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/filter/index.vue b/components/lib/icons/filter/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'FilterIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/filterslash/index.vue b/components/lib/icons/filterslash/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'FilterSlashIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/infocircle/index.vue b/components/lib/icons/infocircle/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'InfoCircleIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/pencil/index.vue b/components/lib/icons/pencil/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'PencilIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/plus/index.vue b/components/lib/icons/plus/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'PlusIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/refresh/index.vue b/components/lib/icons/refresh/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'RefreshIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/search/index.vue b/components/lib/icons/search/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'SearchIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/searchminus/index.vue b/components/lib/icons/searchminus/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'SearchMinusIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/searchplus/index.vue b/components/lib/icons/searchplus/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'SearchPlusIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/sortalt/index.vue b/components/lib/icons/sortalt/index.vue
@@ -22,15 +22,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'SortAltIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/sortamountdown/index.vue b/components/lib/icons/sortamountdown/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'SortAmountDownIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/sortamountupalt/index.vue b/components/lib/icons/sortamountupalt/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'SortAmountUpAltIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/spinner/index.vue b/components/lib/icons/spinner/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'SpinnerIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/star/index.vue b/components/lib/icons/star/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'StarIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/starfill/index.vue b/components/lib/icons/starfill/index.vue
@@ -16,15 +16,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'StarFillIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/thlarge/index.vue b/components/lib/icons/thlarge/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'ThLargeIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>
diff --git a/components/lib/icons/timescircle/index.vue b/components/lib/icons/timescircle/index.vue
@@ -18,15 +18,9 @@
 
 <script>
 import BaseIcon from 'primevue/baseicon';
-import { UniqueComponentId } from 'primevue/utils';
 
 export default {
     name: 'TimesCircleIcon',
-    extends: BaseIcon,
-    computed: {
-        pathId() {
-            return `pv_icon_clip_${UniqueComponentId()}`;
-        }
-    }
+    extends: BaseIcon
 };
 </script>