Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel Icons #890

Closed
wants to merge 2 commits into from
Closed

Panel Icons #890

wants to merge 2 commits into from

Conversation

JOSE89
Copy link

@JOSE89 JOSE89 commented May 17, 2019

###Defect Fixes
When submitting a PR, please also create an issue documenting the error.

###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

Jose added 2 commits May 17, 2019 11:22
icons
Icon Panel
@JOSE89
Copy link
Author

JOSE89 commented May 17, 2019

I've done the PR!

@TonisPiip
Copy link
Contributor

PR is for issue #888

@TonisPiip
Copy link
Contributor

Looking at the commits, I have a feeling that they're not going to accept them.
You've changed quite a bit including things in their package.json.
If you want any PR to be accpeted in any repo you should have the changes clear and to the point.
Changing some minor formating such as {foobar} to { foobar } and other things makes it harder for them to review and less likely to accept.

@JOSE89 JOSE89 closed this May 17, 2019
@JOSE89
Copy link
Author

JOSE89 commented May 17, 2019

PR Panel Icons without spaces #893

@JOSE89 JOSE89 reopened this May 17, 2019
@JOSE89 JOSE89 closed this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants