Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: Allow to be inline on first render. #7342

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Oct 15, 2024

fix #7341 and fix #6838

Defect Fixes

When submitting a PR, please also create an issue documenting the error and manually link to an issue or mention it in the description using #<issue_id>.

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 9:35am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 9:35am

@Et7f3
Copy link
Contributor Author

Et7f3 commented Oct 15, 2024

Could you help me with my hacktoberfest goal by tagging this issue as hacktoberfest-accepted if you consider this issue as valuable (I think since I fixed one bug it can be considered as such).

[participating] Your PR/MRs must be in a repo tagged with the “hacktoberfest” topic, or have the “hacktoberfest-accepted” label.

Hacktoberfest is now opt-in for maintainers, so only contribute to projects that indicate they’re looking for Hacktoberfest PR/MRs.

Once your PR/MR has passed this check, we won’t check this again (unless your PR/MR fails a check before this, such as it being marked as spammy).

Your PR/MR must match criteria to be considered participating before Hacktoberfest ends on October 31 (in any time zone, UTC-12 thru UTC+14) to be counted.

Their is no parent when we are inline so overlayRef is empty.

Co-authored-by: Melloware <[email protected]>
@Et7f3 Et7f3 requested a review from melloware October 16, 2024 09:35
@melloware melloware merged commit 010eab5 into primefaces:master Oct 16, 2024
5 checks passed
@Et7f3 Et7f3 deleted the patch-1 branch October 16, 2024 12:09
@Et7f3
Copy link
Contributor Author

Et7f3 commented Oct 16, 2024

fix #6838

(it was not closed automatically)

So this repo doesn't want to participate in hacktoberfest ?

@melloware
Copy link
Member

I would add the tag if I owned the repo but I can't!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants