-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #7330, AutoComplete: Selected item is not getting highlighted when visited again unlike Dropdown component #7331
Conversation
…lighted when visited again unlike Dropdown component
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
@@ -84,6 +85,10 @@ const styles = ` | |||
padding: 0; | |||
list-style-type: none; | |||
} | |||
|
|||
.selected { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selected is weird should it be p-selected
or is this what the other component does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to p-highlight similar to dropdown component.
…lighted when visited again unlike Dropdown component
@@ -86,7 +86,7 @@ const styles = ` | |||
list-style-type: none; | |||
} | |||
|
|||
.selected { | |||
.p-highlight { | |||
background-color: rgba(6, 182, 212, 0.24) !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be !important
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the style added for p-highlight as a default style was already applied for autocomplete p-highlight class, and its working as expected.
…lighted when visited again unlike Dropdown component
Defect Fixes
fix: #7330, AutoComplete: Selected item is not getting highlighted when visited again unlike Dropdown component