Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #7330, AutoComplete: Selected item is not getting highlighted when visited again unlike Dropdown component #7331

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

akshayaqburst
Copy link
Contributor

Defect Fixes

fix: #7330, AutoComplete: Selected item is not getting highlighted when visited again unlike Dropdown component

…lighted when visited again unlike Dropdown component
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 7:09am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 7:09am

@@ -84,6 +85,10 @@ const styles = `
padding: 0;
list-style-type: none;
}

.selected {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selected is weird should it be p-selected or is this what the other component does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to p-highlight similar to dropdown component.

…lighted when visited again unlike Dropdown component
@@ -86,7 +86,7 @@ const styles = `
list-style-type: none;
}

.selected {
.p-highlight {
background-color: rgba(6, 182, 212, 0.24) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be !important ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the style added for p-highlight as a default style was already applied for autocomplete p-highlight class, and its working as expected.

…lighted when visited again unlike Dropdown component
@melloware melloware merged commit 57f2917 into primefaces:master Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoComplete: Selected item is not getting highlighted when visited again unlike Dropdown component
2 participants