fix(steps): make active step controlled via props #7300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Did you test it in Controlled AND uncontrolled mode. Typically PR stored that in a |
|
Yes @melloware I checked! Like I said because of using state here Screen.Recording.2024-10-02.at.22.51.02.mov |
melloware
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7298
Fix #7303
before
Screen.Recording.2024-10-02.at.22.07.11.mov
after
Screen.Recording.2024-10-02.at.22.07.32.mov
We shouldn't use
useStatefor dynamic change here we need to useprops.activeIndexdirectly.Also, I checked It doesn't broke other step examples.