Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed DataTable thead z-index (#7258) #7268

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

skj-skj
Copy link
Contributor

@skj-skj skj-skj commented Sep 28, 2024

Defect Fixes

Fix #7258

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 8:12am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 8:12am

@skj-skj
Copy link
Contributor Author

skj-skj commented Sep 28, 2024

hi @melloware,
I have added a fix for header checkbox not working properly, the solution is to update the z-index from 1 to higher number in the .p-datatable-scrollable-table > .p-datatable-thead css.

I haven't discussed with project members as per the contributing guidelines before making this pull request as I was unsure that I would be able to find a solution.

I have my doubts that this fix seems too easy, which makes me thing "am I missing something?"
can you please review it? if anyone else from the project members are working on this issue you can close this pull request.

Thanks.

@melloware
Copy link
Member

LGTM!

@melloware melloware merged commit c330980 into primefaces:master Sep 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable: Select all checkbox on header row not working properly when scrollable is true
2 participants