Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reflect changed year when selecting date in month view #7257

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

KumJungMin
Copy link
Contributor

Defect Fixes



Test

I have verified four conditions in the Calendar year selection.

  1. When changing the year in the normal mode and selecting a date, the changed year should be reflected.
<Calendar value={date} onChange={(e) => setDate(e.value)}  />
2024-09-26.8.17.54.mp4



  1. When numberOfMonths is 2 or more, multiple years should be displayed. (e.g., Dec 2023, Jan 2024)
<Calendar value={date} onChange={(e) => setDate(e.value)}  numberOfMonths={3} />
2024-09-26.8.31.50.mp4



  1. When numberOfMonths > 1 and in YearNavigator mode:
    3-1. Multiple years should be displayed.
    3-2. When changing the year and selecting a date, the changed year should be reflected.
<Calendar value={date} onChange={(e) => setDate(e.value)}  numberOfMonths={3} YearNavigator />
2024-09-26.8.40.23.mp4



  1. In YearNavigator mode, when changing the year and selecting a date, the changed year should be reflected.
<Calendar value={date} onChange={(e) => setDate(e.value)}  YearNavigator />
2024-09-26.8.18.42.mp4

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 11:57am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 11:57am

@KumJungMin KumJungMin changed the title fix: show current year when select year in month view fix: reflect changed year when selecting date in month view Sep 26, 2024
@melloware melloware merged commit 92de1eb into primefaces:master Sep 26, 2024
5 checks passed
@melloware
Copy link
Member

Thanks @KumJungMin !

@KumJungMin KumJungMin deleted the fix/issue-7254 branch September 26, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar: selecting a new year is not being reflected when transitioning to the month view.
2 participants