fix: #7200 Fix Drag Selection for Datatable #7217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Don't restructure `originalEvent` in `allowRowDrag`, just pass the full event through from `onRowDragStart`
melloware
approved these changes
Sep 19, 2024
|
I still experience the problem on 10.8.4. Can't select cell's data. The cell is dragged instead. Also would be good to update official documentation on primereact.org to 10.8.4. The problem can be reproducing on the datatable's page. |
|
the bug is still present on 10.8.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
fix: #7200 Fix Drag Selection for Datatable
Fix #7221
The existing implementation of
allowRowDragtakes an "event" and passes it through toallowDrag, howeverallowDragexpects theeventparameter to haveoriginalEventas a property. This PR fixes that issue.