-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dropdown): get option value judgment logic #7083
perf(dropdown): get option value judgment logic #7083
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
This won't fix the issue, optionValue should always be returned if it was defined in props even if its null or "" |
@mtsh1000 is correct this doesn't fix it. however what if the original optionValue was also NULL or "" how would the component know that is what you are using? |
Co-authored-by: Melloware <[email protected]>
Actually I changed it to |
Great, thats the proper fix, thank you:) |
I think now i actually have the best correct fix. If either |
Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue or mention it in the description using #<issue_id>.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.
close #7064
Fix #7081
Fix #6617