Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #7042 Add Tailwind styling for IconField #7066

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

gcko
Copy link
Contributor

@gcko gcko commented Aug 21, 2024

Defect Fixes

Fixes #7042

  • Create unstyled theme docs for IconField
  • Ensure iconPosition is passed contextually to the children of IconField
  • Use iconPosition to properly style InputIcon and InputText when it is enabled

- Create unstyled theme docs for IconField
- Ensure iconPosition is passed contextually to the children of IconField
- Use iconPosition to properly style InputIcon and InputText when it is enabled
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 11:08am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 11:08am

@nitrogenous
Copy link
Contributor

Thanks for the PR. We're trying to keep our library structures synced, so we'll check this core update and get back to you.

@gcko
Copy link
Contributor Author

gcko commented Aug 21, 2024

@nitrogenous Of course. Please check here for more info regarding the proposed fix: #7042 (comment)

Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you for your PR; we really appreciate it. We’d love to see you contribute more often

@nitrogenous nitrogenous merged commit 03023fe into primefaces:master Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IconField: icons do not appear inside the visual input area in Tailwind
2 participants