Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(panelmenu): replace submenuIcon with expandIcon and collapse… #7031

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

franmc01
Copy link
Contributor

Description

This PR addresses the need to replace the deprecated submenuIcon prop with expandIcon and collapseIcon in the PanelMenu component, enhancing the flexibility and customization of icons used in expanded and collapsed states.

Changes Made

  • Replaced submenuIcon with expandIcon and collapseIcon in PanelMenuList, PanelMenuSub, and related components.
  • Updated TypeScript definitions to reflect the new properties.
  • Added passthrough options for expandIcon and collapseIcon.
  • Updated styles and removed references to submenuIcon.

Related Issue

This PR resolves Issue #7026.

Tasks

  • Implemented expandIcon and collapseIcon.
  • Updated TypeScript definitions.
  • Modified styles and removed submenuIcon.
  • Update documentation to reflect the changes.
  • Add examples for using expandIcon and collapseIcon.

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 11:24am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 11:24am

@melloware melloware requested a review from nitrogenous August 12, 2024 18:42
@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 12, 2024
@melloware
Copy link
Member

Looks like build is failing. I assigned to Primetek to review.

@nitrogenous
Copy link
Contributor

Thanks for your contributions! I also updated the API documentation in this PR. I appreciate your efforts, and I look forward to seeing more of your work. LGTM

@nitrogenous nitrogenous merged commit 34229f9 into primefaces:master Aug 21, 2024
3 of 4 checks passed
@franmc01
Copy link
Contributor Author

Thanks for your contributions! I also updated the API documentation in this PR. I appreciate your efforts, and I look forward to seeing more of your work. LGTM

Thank you for the feedback and for updating the API documentation! I appreciate your kind words and am glad to hear that everything looks good to you. I’m excited to continue contributing and working together.

Best regards,
Francisco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanelMenu: Cannot change icon when expanding or compressing submenu
3 participants