Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6691: fix default editMode value #6692

Merged
merged 4 commits into from
May 28, 2024
Merged

Fix #6691: fix default editMode value #6692

merged 4 commits into from
May 28, 2024

Conversation

Rekl0w
Copy link
Contributor

@Rekl0w Rekl0w commented May 28, 2024

Fix #6691: fix default editMode value

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 3:30pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 3:30pm

@melloware
Copy link
Member

This would make all tables now edit cell by default? I think the TS def should update to default NULL.

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 28, 2024
@Rekl0w
Copy link
Contributor Author

Rekl0w commented May 28, 2024

You're right about it. I'll change the docs.

@melloware
Copy link
Member

I updated your PR to update the TS file which generates the docs.

@melloware melloware removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 28, 2024
@melloware melloware merged commit da6ce28 into primefaces:master May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc say DataTable editMode default is "cell" but its Null
2 participants