Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing prop in SidebarPassThroughMethodOptions #6689

Merged
merged 4 commits into from
May 27, 2024
Merged

fix: Missing prop in SidebarPassThroughMethodOptions #6689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db71189
fix: Error in type definition
ivanpajon May 25, 2024
0ccdfc8
Merge branch 'fix/inputtextprops'
ivanpajon May 25, 2024
d373b6f
Merge branch 'master' of https://github.com/ivanpajon/primereact
ivanpajon May 25, 2024
ebad222
fix: Missing closeButton prop in SidebarPassThroughMethodOptions
ivanpajon May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion components/doc/common/apidoc/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44884,12 +44884,19 @@
"type": "SidebarPassThroughType<HTMLAttributes<HTMLDivElement>>",
"description": "Uses to pass attributes to the header's DOM element."
},
{
"name": "closeButton",
"optional": true,
"readonly": false,
"type": "SidebarPassThroughType<HTMLAttributes<HTMLButtonElement>>",
"description": "Uses to pass attributes to the close button's DOM element."
},
{
"name": "closeButtonIcon",
"optional": true,
"readonly": false,
"type": "SidebarPassThroughType<HTMLAttributes<HTMLSpanElement>>",
"description": "Uses to pass attributes to the close button's DOM element."
"description": "Uses to pass attributes to the close button icon's DOM element."
},
{
"name": "icons",
Expand Down
4 changes: 4 additions & 0 deletions components/lib/sidebar/sidebar.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ export interface SidebarPassThroughOptions {
/**
* Uses to pass attributes to the close button's DOM element.
*/
closeButton?: SidebarPassThroughType<React.HTMLAttributes<HTMLButtonElement>>;
/**
* Uses to pass attributes to the close button icon's DOM element.
*/
closeButtonIcon?: SidebarPassThroughType<React.HTMLAttributes<HTMLSpanElement>>;
/**
* Uses to pass attributes to the custom icons content's DOM element.
Expand Down
Loading