Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emptyMessage prop and default label in unstyled mode #6672

Merged
merged 6 commits into from
May 26, 2024

Conversation

ivanpajon
Copy link
Contributor

Defect Fixes

Fix #6671

When no emptyMessage is defined and no option is selected the component internally use a   so it not loses its height.

Without  :
without nbsp

With  :
with nbsp

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview May 26, 2024 3:00pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview May 26, 2024 3:00pm

@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label May 26, 2024
Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of suggestions. WDYT?

components/lib/dropdown/Dropdown.js Outdated Show resolved Hide resolved
components/lib/dropdown/Dropdown.js Outdated Show resolved Hide resolved
@ivanpajon
Copy link
Contributor Author

It looks cleaner, I like it. Thanks!

@melloware melloware merged commit c65c58b into primefaces:master May 26, 2024
5 checks passed
@ivanpajon ivanpajon deleted the fix/dropdown-empty-message branch May 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: emptyMessage prop doesn't work
2 participants