Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/date picker value entering #6478

Merged

Conversation

KirilCycle
Copy link
Contributor

@KirilCycle KirilCycle commented Apr 26, 2024

Fix #6099
Fix #3728 does not appear with changes
Fix #5986 does not appear
Fix #6380 does not appear

Description

Now calendar can work with short date format like 2024.03.1, and on blur it will roll back to standard date format '2024.03.01'. Similar to vueprime behaviour.

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2024 4:53pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2024 4:53pm

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

Nice appreciate you keeping your eye on how Primevue is doing it!

@KirilCycle
Copy link
Contributor Author

Nice appreciate you keeping your eye on how Primevue is doing it!

Thanks!

@KirilCycle KirilCycle marked this pull request as ready for review April 26, 2024 13:29
@KirilCycle KirilCycle marked this pull request as draft April 27, 2024 11:43
@KirilCycle
Copy link
Contributor Author

Let me look deeper

@KirilCycle KirilCycle marked this pull request as ready for review April 27, 2024 12:49
@KirilCycle KirilCycle requested a review from melloware April 27, 2024 13:10
components/lib/calendar/Calendar.js Outdated Show resolved Hide resolved
@KirilCycle KirilCycle requested a review from melloware April 27, 2024 16:56
@melloware
Copy link
Member

@KirilCycle can you also test these tickets with your fix. It seems this has been reported many times.

#3728

#4134

#5986

#6380

Thanks! Let me know if your fix addresses any of these so I can mark this PR accordingly

@KirilCycle
Copy link
Contributor Author

@KirilCycle can you also test these tickets with your fix. It seems this has been reported many times.

#3728

#4134

#5986

#6380

Thanks! Let me know if your fix addresses any of these so I can mark this PR accordingly

Hello! Yes ill take a look

Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contributions

@nitrogenous nitrogenous merged commit 68a7593 into primefaces:master Apr 29, 2024
5 checks passed
@KirilCycle
Copy link
Contributor Author

LGTM. Thanks for your contributions

My God, my first contribution to a huge project, I'm so happy :)

@nitrogenous
Copy link
Contributor

@KirilCycle can you also test these tickets with your fix. It seems this has been reported many times.

#3728

#4134

#5986

#6380

Thanks! Let me know if your fix addresses any of these so I can mark this PR accordingly

We will close those issues if they are related  🙏

@KirilCycle
Copy link
Contributor Author

KirilCycle commented Apr 29, 2024

@KirilCycle can you also test these tickets with your fix. It seems this has been reported many times.
#3728
#4134
#5986
#6380
Thanks! Let me know if your fix addresses any of these so I can mark this PR accordingly

We will close those issues if they are related  🙏

#3728 does not appear with changes
#4134 still exist
#5986 does not appear
#6380 does not appear

@melloware
Copy link
Member

Thanks I linked those other tickets to this PR and closed them also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants