Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5960: Quill 2.0.0 support #6429

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

melloware
Copy link
Member

@melloware melloware commented Apr 20, 2024

Fix #5960: Quill 2.0.0 support

Fix #6492

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Apr 20, 2024
Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 21, 2024 11:59am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 21, 2024 11:59am

@melloware melloware force-pushed the PR5960-editor branch 2 times, most recently from 763d692 to d78cd05 Compare April 20, 2024 12:05
@melloware
Copy link
Member Author

I had to remove the test because of this Jest error which I don't want to invest the time to try and fix as it requires Babel changes.

 SyntaxError: Cannot use import statement outside a module

      49 |                     initQuill(new Quill(contentRef.current, configuration));
      50 |                 } else {
    > 51 |                     import('quill').then((module) => {
         |                     ^
      52 |                         if (module && DomHandler.isExist(contentRef.current)) {
      53 |                             let quillInstance;
      54 |

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)

@melloware melloware requested review from gucal and nitrogenous April 22, 2024 11:34
@nitrogenous nitrogenous added the Status: Pending Test Issue or pull request is being tested by Core Team label Apr 25, 2024
Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work

@nitrogenous nitrogenous removed the Status: Pending Test Issue or pull request is being tested by Core Team label Apr 29, 2024
@nitrogenous nitrogenous merged commit 689cdf6 into primefaces:master Apr 29, 2024
5 checks passed
@melloware melloware deleted the PR5960-editor branch April 29, 2024 12:58
@arikardnoir
Copy link

arikardnoir commented May 3, 2024

Someone here know how to solve the problem that occurs when im trying to type something at Editor and the value disappear ?
Using at Google Chrome on Windows.

@melloware
Copy link
Member Author

@arikardnoir working fine for me? See: https://stackblitz.com/edit/byre3c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value initially not being displayed on the Editor Component Editor: Support for Quill 2.0.0
3 participants