Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Merging PT props only respects lower-case props #6292

Merged
merged 23 commits into from
Apr 4, 2024

Conversation

vaelu
Copy link
Contributor

@vaelu vaelu commented Apr 3, 2024

Fixes #6289.

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 7:00am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 7:00am

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

checkbox is missing from TriStateCheckbox component definition: https://github.com/primefaces/primereact/blob/master/components/lib/passthrough/tailwind/index.js#L1032-L1045

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

@melloware @nitrogenous Is a class array deliberately used here instead of an object with className? https://github.com/primefaces/primereact/blob/master/components/lib/passthrough/tailwind/index.js#L2164-L2260

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

indicatorbutton is missing from Galleria component definition: https://github.com/primefaces/primereact/blob/master/components/lib/passthrough/tailwind/index.js#L2367-L2372

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

targetcontrols, targetwrapper, targetheader, targetlist and transition are missing from PickList component definition: https://github.com/primefaces/primereact/blob/master/components/lib/passthrough/tailwind/index.js#L2874-L2888

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

jumptopagedropdown (or like the other namings are JTPDropdown) is missing from Paginator component definition: https://github.com/primefaces/primereact/blob/master/components/lib/passthrough/tailwind/index.js#L3027-L3041

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

footercell, checkboxwrapper, checkbox, checkboxIcon, rowreordericon, radiobuttonwrapper, radiobutton, radiobuttonicon, headercheckboxwrapper and headercheckboxicon are missing from Column component definition: https://github.com/primefaces/primereact/blob/master/components/lib/passthrough/tailwind/index.js#L3205-L3225

@vaelu
Copy link
Contributor Author

vaelu commented Apr 3, 2024

rowgrouptoggler and rowgrouptogglericon are missing from DataTable component definition: https://github.com/primefaces/primereact/blob/master/components/lib/passthrough/tailwind/index.js#L3502-L3511

Copy link

github-actions bot commented Apr 3, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

Copy link

github-actions bot commented Apr 4, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@vaelu vaelu marked this pull request as ready for review April 4, 2024 07:17
@vaelu
Copy link
Contributor Author

vaelu commented Apr 4, 2024

@melloware Ready to merge.

@melloware melloware merged commit 6af7a11 into primefaces:master Apr 4, 2024
3 of 5 checks passed
@melloware melloware added the Component: Tailwind Tailwind specific issue label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core: Merging PT props only respects lower-case props
2 participants