Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree TreeTable Structure Enhancement #6241

Merged

Conversation

nitrogenous
Copy link
Contributor

@nitrogenous nitrogenous commented Mar 28, 2024

Fix #6240

Treetable

  • Removed custom checkbox
  • Removed hidden input wrapper
  • Added primereact checkbox

Tree

  • Removed custom checkbox
  • Added primereact checkbox

@nitrogenous nitrogenous self-assigned this Mar 28, 2024
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@nitrogenous
Copy link
Contributor Author

#6240

@melloware
Copy link
Member

i assume Datatable and MultiSelect will get the same checkbox treatment?

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Mar 28, 2024
@nitrogenous
Copy link
Contributor Author

i assume Datatable and MultiSelect will get the same checkbox treatment?

Yes @gucal was working on those components

@nitrogenous nitrogenous merged commit bef605d into primefaces:master Mar 29, 2024
6 of 11 checks passed
@nitrogenous nitrogenous deleted the component-checkbox-enhancements branch March 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component structure enhancement - Tree TreeTable
2 participants