Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue - #5540 - Bugfix: fixed animations not working correctly on TRANSITION.toggleable with tailwind preset #6167

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

Tarik1700
Copy link
Contributor

@Tarik1700 Tarik1700 commented Mar 16, 2024

Fix #5540

Description

Tested locally with PanelMenu component, will attach a video of it working below, referenced the animation style from other components which did not use the tailwind preset, i suppose the h-40 was not enough to show more than 3 items in a list hence the cut-off in the animation.
Also another issue that was mentioned inside the same ticket is that sometimes the close animation was a bit delayed, also fixed that with the ease-out classname for the exitActive

Preview

Screen.Recording.2024-03-16.at.14.21.10.mov

Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 10:19am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 10:19am

@Tarik1700
Copy link
Contributor Author

@melloware fixed the issue we talked about yesterday, please take a look when free

@melloware melloware added the Component: Tailwind Tailwind specific issue label Mar 16, 2024
@melloware
Copy link
Member

Nice Fix!

@MaNemoj01
Copy link

Awesome job @Tarik1700 :D

Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine

@nitrogenous nitrogenous merged commit 5a353ca into primefaces:master Mar 18, 2024
3 of 5 checks passed
@melloware
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion/PanelMenu: (Tailwind) animation issues
4 participants