Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure enhancements #6109

Merged
merged 21 commits into from
Mar 13, 2024
Merged

Structure enhancements #6109

merged 21 commits into from
Mar 13, 2024

Conversation

nitrogenous
Copy link
Contributor

@nitrogenous nitrogenous commented Mar 7, 2024 •
edited
Loading

Structures Updated

  • Checkbox
  • ToggleButton
  • RadioButton
  • InputSwitch
  • TriStateCheckbox

Affected Components;

  • Checkbox
  • ToggleButton
  • RadioButton
  • InputSwitch
  • TriStateCheckbox

Changes;

Checkbox

Removed

  • hiddenInputWrapper and hiddenInput from pt options
  • click focus and blur from emits
  • focused state

Added

  • box to pt options

RadioButton

Removed

  • hiddenInputWrapper and hiddenInput from pt options
  • click focus and blur from emits
  • focused state

Added

  • box to pt options

TriStateCheckbox

Removed

  • hiddenInputWrapper, hiddenInput and checkbox from pt options
  • click focus and blur from emits
  • focusedstate

Added

  • box and input to pt options
  • readonly to props

InputSwitch

Removed

  • hiddenInputWrapper and hiddenInput from pt options
  • click focus and blur from emits
  • focused state

Added

  • input to pt options

ToggleButton

Removed

  • hiddenInputWrapper and hiddenInput from pt options
  • click focus and blur from emits
  • focused state

Added

  • input and box to pt options
  • readonly to props

@nitrogenous
Merge remote-tracking branch 'upstream/master'
f6f7b16
@nitrogenous
Merge remote-tracking branch 'upstream/master'
5862c8c
@nitrogenous
Updated structure of checkbox
0454f97
@nitrogenous
Checkbox styles update
9ad8c24
@nitrogenous
RadioButton structure update
6c9181f
@nitrogenous
Checkbox default styles
7b7bba8
@nitrogenous
Radio button typo fix and api doc update
0c44b0f
@nitrogenous
Updated apidoc files
2c93056
@nitrogenous
InputSwitch structure update
6894603
@nitrogenous
Removed unnecessary debugging lines
23c0983
@nitrogenous
Added readonly and invalid props
2a0c5c0
@nitrogenous
ToggleButton structure update
6396f23
@nitrogenous
Tristatecheckbox structure update
2ead305
@nitrogenous
Updated structure of checkbox
c73f8c2 
Checkbox styles update

RadioButton structure update

Checkbox default styles

Radio button typo fix and api doc update

Updated apidoc files

InputSwitch structure update

Removed unnecessary debugging lines

Added readonly and invalid props

ToggleButton structure update

Tristatecheckbox structure update
@nitrogenous
Merge branch 'master' into structure-enhancements
f6daeff
@nitrogenous
removed unused line
da3412e
@nitrogenous
Merge remote-tracking branch 'upstream/master' into structure-enhance…
606dc9a 
…ments
@nitrogenous
Moved core stylings and updated themes
2b705eb
@nitrogenous nitrogenous self-assigned this Mar 7, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 1:07pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 1:07pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@nitrogenous
Copy link
Contributor Author

@melloware We are updating our structures to be just like primevue for tailwind primereact so we don't need focused stated and some other things.

@melloware
Copy link
Member

Awesome!

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@nitrogenous nitrogenous merged commit 2d66a30 into primefaces:master Mar 13, 2024
2 of 6 checks passed
@nitrogenous nitrogenous deleted the structure-enhancements branch March 13, 2024 13:07
@dvpritzbuer dvpritzbuer mentioned this pull request Apr 26, 2024
Closed
@felpereira felpereira mentioned this pull request Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware left review comments

@mertsincan mertsincan Awaiting requested review from mertsincan

@tugcekucukoglu tugcekucukoglu Awaiting requested review from tugcekucukoglu

@gucal gucal Awaiting requested review from gucal

Assignees

@nitrogenous nitrogenous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrogenous @melloware