Fix #6101: Slider: event.value in onSlideEnd returns null on touch devices

[kl-nevermore]

Fix #6101

• The event of touchend does not contain touches
• Use changedTouches with reference to MUI
• query via caniuse is not supported on safari
  • but tested in iOS17 and iOS15.8, it worked

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
primereact	⬜️ Ignored (Inspect)	Visit Preview		Mar 7, 2024 1:03pm
primereact-v9	⬜️ Ignored (Inspect)	Visit Preview		Mar 7, 2024 1:03pm

[melloware]

@kl-nevermore can you try this more concise version?

const trackTouch = (event) => {
    const changedTouch = event.changedTouches?.find(touch => touch.identifier === touchId.current);

    if (changedTouch) {
        return {
            pageX: changedTouch.pageX,
            pageY: changedTouch.pageY
        };
    }

    return {
        pageX: event.pageX,
        pageY: event.pageY
    };
};

[melloware]

Suggested change

	const trackFinger = (event) => {
	const trackTouch= (event) => {

[kl-nevermore]

@kl-nevermore can you try this more concise version?

const trackTouch = (event) => {
    const changedTouch = event.changedTouches?.find(touch => touch.identifier === touchId.current);

    if (changedTouch) {
        return {
            pageX: changedTouch.pageX,
            pageY: changedTouch.pageY
        };
    }

    return {
        pageX: event.pageX,
        pageY: event.pageY
    };
};

it is a TouchList

[melloware]

OK then just rename to trackTouch and I think we are good.

[kl-nevermore]

maybe?

 const trackTouch = (_event) => {
            const event = Array.from(_event.changedTouches ?? []).find((t) => t.identifier === touchId.current) || _event;

            return {
                pageX: event.pageX,
                pageY: event.pageY
            };
        };

[melloware]

Oooh I like it!

[melloware]

or reverse it called the param event and the private variable const _event ?

[kl-nevermore]

Updated

[nitrogenous]

superb