Fix: Primereact uses document.getElementById(undefined) for appending… #6081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component styles
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
yikstinis
reviewed
Mar 4, 2024
| @@ -21,7 +21,7 @@ export const useStyle = (css, options = {}) => { | |||
|
|
|||
| const styleContainer = context?.styleContainer || document.head; | |||
|
|
|||
| styleRef.current = styleContainer.querySelector(`style[data-primereact-style-id="${name}"]`) || document.getElementById(id) || document.createElement('style'); | |||
| styleRef.current = styleContainer.querySelector(`style[data-primereact-style-id="${name}"]`) || document.querySelector(`#${id}`) || document.createElement('style'); | |||
There was a problem hiding this comment.
This change won't fix the issue. New selector document.querySelector('#undefined') will select the same element with id="undefined".. :(
There was a problem hiding this comment.
I belive, you have to do something like that:
const getCurrentStyleRef = () => {
const existingStyleContainerChild = styleContainer.querySelector(
`style[data-primereact-style-id="${name}"]`,
);
if (existingStyleContainerChild) {
return existingStyleContainerChild;
}
// First, check that id is defined!
if (id !== undefined) {
// And select element by defined id on the page after:
const existingElementWithId = document.getElementById(id);
if (existingElementWithId) {
return existingElementWithId;
}
}
return document.createElement('style');
};
styleRef.current = getCurrentStyleRef();There was a problem hiding this comment.
Yes, I made a mistake, sorry. I forgot add during the testing with #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6079