-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6068: Documentation Fixes #6069
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
How did you do this did you edit this file? It is auto generated i think the main SideBarbase.js has to be updated? |
Actually you have to fix the order in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Thank you very much. I will update the PR. |
after you make the changes to |
Hi @melloware I am not sure about option 3 in the wireframe. Before modifying the "Sidebar PT Options" I think it should update the wireframe. |
The wireframe is out of our control PrimeTek does that. The best we can do is fix the TS docs... |
I got it. Thank you very much for approving the PR. |
Thank you for your contribution. We are actually thinking about a new system for more dynamic wireframes. We are open for ideas. |
You are welcome. I look forward to more contributions. |
Defect Fixes
Fixed #6068 Sidebar "Pass Through" documentation issue.
Fix: #6070
Fix: #6078
Options 3,4,5 and 6 did not match with the Wireframe.
I fixed the 4,5 and 6 mismatching with this PR.
Current preview: