Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6068: Documentation Fixes #6069

Merged
merged 14 commits into from
Mar 15, 2024
Merged

Conversation

charithAmila
Copy link
Contributor

@charithAmila charithAmila commented Mar 1, 2024

Defect Fixes

Fixed #6068 Sidebar "Pass Through" documentation issue.
Fix: #6070
Fix: #6078

Screen Shot 2024-02-29 at 3 45 20 PM Screen Shot 2024-02-29 at 3 49 00 PM

Options 3,4,5 and 6 did not match with the Wireframe.
I fixed the 4,5 and 6 mismatching with this PR.

Current preview:
Screen Shot 2024-03-01 at 12 20 35 AM

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 0:49am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 0:49am

Copy link

github-actions bot commented Mar 1, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@charithAmila charithAmila marked this pull request as ready for review March 1, 2024 05:25
@melloware
Copy link
Member

How did you do this did you edit this file? It is auto generated i think the main SideBarbase.js has to be updated?

@melloware
Copy link
Member

Actually you have to fix the order in sidebar.d.ts then it will re-generate the docs in that order.

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@melloware melloware added the Component: Documentation Issue or pull request is related to Documentation label Mar 1, 2024
@charithAmila
Copy link
Contributor Author

Actually you have to fix the order in sidebar.d.ts then it will re-generate the docs in that order.

Thank you very much. I will update the PR.

@melloware
Copy link
Member

after you make the changes to .d.ts then run npm run build:api that will regenerate the index.json from your TS changes.

@charithAmila
Copy link
Contributor Author

Hi @melloware
I fixed options 4,5 and 6.

I am not sure about option 3 in the wireframe. Before modifying the "Sidebar PT Options" I think it should update the wireframe.

Screen Shot 2024-03-01 at 9 57 38 AM

@melloware
Copy link
Member

The wireframe is out of our control PrimeTek does that. The best we can do is fix the TS docs...

@charithAmila
Copy link
Contributor Author

I got it. Thank you very much for approving the PR.

@melloware melloware added this to the 10.5.2 milestone Mar 1, 2024
@melloware melloware changed the title Fix #6068: Sidebar "Pass Through" documentation issue Fix #6068: Documentation Fixes Mar 1, 2024
@nitrogenous
Copy link
Contributor

Thank you for your contribution. We are actually thinking about a new system for more dynamic wireframes. We are open for ideas.

@nitrogenous nitrogenous merged commit f233199 into primefaces:master Mar 15, 2024
5 checks passed
@charithAmila
Copy link
Contributor Author

You are welcome. I look forward to more contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
4 participants