BodyRows merge rowClassName properly #5983 #5995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
requested changes
Feb 17, 2024
Et7f3
force-pushed
the
fix_merge_rowClassName
branch
from
88eee1c to
60944be
Compare
Co-authored-by: Melloware <[email protected]>
melloware
approved these changes
Feb 17, 2024
|
Nevermind I see what broke it and it wasn't this change @Et7f3 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5983
Thanks for your quick reply and code indication @melloware,
Even though it works! I digged a bit and found the issue to happened elsewhere (the
mergePropsfunction).What is done in this PR:
classNameMergeFunctionprops becausecontext.classNameMergeFunctionwas undefined (and from docs it seems to be a left over of an old doc where it wasn't nested)classNames(cx('bodyRow', { rowProps: props }), rowClassName)but I think it could allow to overridebg-row-oddbut I am not sure.This PR doesn't have test because I don't know how to write them (I am not a front end guy). I just tested by modifying the documentation example and see if it works.
before/after:
PS: you know you can copy permalink so you can directly jumps to code
primereact/components/lib/datatable/BodyRow.js
Line 471 in 0083b8d