Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5849: Splitter improve ARIA accessibility #5853

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix #5849: Splitter improve ARIA accessibility #5853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/lib/splitter/Splitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ export const Splitter = React.memo(
onTouchMove: (event) => onGutterTouchMove(event),
onTouchEnd: (event) => onGutterTouchEnd(event),
'data-p-splitter-gutter-resizing': false,
role: 'splitter'
role: 'separator'
},
ptm('gutter')
);
Expand Down
14 changes: 7 additions & 7 deletions components/lib/splitter/__snapshots__/Splitter.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ exports[`Splitter Nested 1`] = `
class="p-splitter-gutter"
data-p-splitter-gutter-resizing="false"
data-pc-section="gutter"
role="splitter"
role="separator"
style="width: 4px;"
>
<div
Expand Down Expand Up @@ -66,7 +66,7 @@ exports[`Splitter Nested 1`] = `
class="p-splitter-gutter"
data-p-splitter-gutter-resizing="false"
data-pc-section="gutter"
role="splitter"
role="separator"
style="height: 4px;"
>
<div
Expand Down Expand Up @@ -109,7 +109,7 @@ exports[`Splitter Nested 1`] = `
class="p-splitter-gutter"
data-p-splitter-gutter-resizing="false"
data-pc-section="gutter"
role="splitter"
role="separator"
style="width: 4px;"
>
<div
Expand Down Expand Up @@ -165,7 +165,7 @@ exports[`Splitter Single Panel with size 1`] = `
class="p-splitter-gutter"
data-p-splitter-gutter-resizing="false"
data-pc-section="gutter"
role="splitter"
role="separator"
style="height: 4px;"
>
<div
Expand Down Expand Up @@ -207,7 +207,7 @@ exports[`Splitter Single Panel without size 1`] = `
class="p-splitter-gutter"
data-p-splitter-gutter-resizing="false"
data-pc-section="gutter"
role="splitter"
role="separator"
style="height: 4px;"
>
<div
Expand Down Expand Up @@ -249,7 +249,7 @@ exports[`Splitter Splitter requires two SplitterPanel components to wrap. 1`] =
class="p-splitter-gutter"
data-p-splitter-gutter-resizing="false"
data-pc-section="gutter"
role="splitter"
role="separator"
style="width: 4px;"
>
<div
Expand Down Expand Up @@ -301,7 +301,7 @@ exports[`Splitter Vertical layout 1`] = `
class="p-splitter-gutter"
data-p-splitter-gutter-resizing="false"
data-pc-section="gutter"
role="splitter"
role="separator"
style="height: 4px;"
>
<div
Expand Down
Loading