Enhancement: DataTable accessibility #5839
Conversation
nitrogenous
added
Type: Enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
components/lib/datatable/BodyRow.js
Outdated
| @@ -152,44 +164,37 @@ export const BodyRow = React.memo((props) => { | |||
| switch (event.which) { | |||
| //down arrow | |||
| case 40: | |||
There was a problem hiding this comment.
We should switch those to event.code like 'ArrowDown' etc. the old event.which is deprecated
| @@ -169,7 +169,7 @@ export const HeaderCell = React.memo((props) => { | |||
| }; | |||
|
|
|||
| const onKeyDown = (event) => { | |||
| if (event.key === 'Enter' && event.currentTarget === elementRef.current && DomHandler.getAttribute(event.currentTarget, 'data-p-sortable-column') === 'true') { | |||
| if ((event.which == 13 || event.which == 32) && event.currentTarget === elementRef.current && DomHandler.getAttribute(event.currentTarget, 'data-p-sortable-column') === 'true') { | |||
| onClick(event); | |||
There was a problem hiding this comment.
I don't think we want to use event.which anymore it should all be event.code right?
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
#5799