Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5699: MegaMenu strict mode fix #5700

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

melloware
Copy link
Member

@melloware melloware commented Jan 7, 2024

Fix #5699: MegaMenu strict mode fix

  • Group all effects together in the code
  • props.model must be a normal effect and not a updateEffect
  • Respect isMobileMode changes

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Jan 7, 2024
Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2024 3:16pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2024 3:16pm

@melloware melloware merged commit b6aee40 into primefaces:master Jan 7, 2024
6 checks passed
@melloware melloware deleted the megamenu branch January 7, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MegaMenu: Menu Items not showing without StrictMode (production) only after a stateupdate
1 participant