Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Ripple and Tabview bugs in Next.js App Router #5674

Merged
merged 5 commits into from
Jan 3, 2024
Merged

fix:Ripple and Tabview bugs in Next.js App Router #5674

merged 5 commits into from
Jan 3, 2024

Conversation

kl-nevermore
Copy link
Contributor

@kl-nevermore kl-nevermore commented Jan 2, 2024 •
edited
Loading

Because I use Next14 in my project, So I fixed the forked project
Should we wait for PrimeTek to fix it or use a temporary solution first?

Fix #5395

Fix #5127 refer to vercel/next.js#17443 (comment)

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 0:21am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 0:21am

melloware
melloware requested changes Jan 2, 2024
View reviewed changes
components/lib/ripple/Ripple.js Outdated Show resolved Hide resolved
@melloware melloware added the Type: SSR Issue related to server side rendering label Jan 2, 2024
@kl-nevermore kl-nevermore marked this pull request as ready for review January 3, 2024 08:25
@kl-nevermore
Copy link
Contributor Author

kl-nevermore commented Jan 3, 2024 •
edited
Loading

  • tested Page Router in ^12, ^13, ^14
    • break in 13 14
  • tested App Router in ^14
    • if use App Router, Requires Next.js >=14

@kl-nevermore kl-nevermore marked this pull request as draft January 3, 2024 09:43
@kl-nevermore kl-nevermore marked this pull request as ready for review January 3, 2024 10:04
@kl-nevermore kl-nevermore changed the title fix:Ripple and Tabview bugs in next.js >= 13 fix:Ripple and Tabview bugs in Next.js App Router Jan 3, 2024
@kl-nevermore kl-nevermore marked this pull request as draft January 3, 2024 10:30
@melloware melloware marked this pull request as ready for review January 3, 2024 12:22
@melloware melloware merged commit c7fe6c9 into primefaces:master Jan 3, 2024
6 checks passed
@kl-nevermore kl-nevermore deleted the next.js branch January 3, 2024 12:28
nitrogenous pushed a commit that referenced this pull request Jan 4, 2024
@kl-nevermore @yigitfindikli @nitrogenous
fix:Ripple and Tabview bugs in Next.js App Router (#5674)
1fde3e3 
* fix:Ripple and Tabview bugs in next.js >= 13

* #5675 Theme update for OrderList

* fix: Remove unnecessary code

* Update comment

* fix: break Ripple when use Page Router

---------

Co-authored-by: Yiğit FINDIKLI <[email protected]>
@kl-nevermore kl-nevermore mentioned this pull request Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
Type: SSR Issue related to server side rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabView: Doesn't render in NextJS 14 PrimeReactProvider: Error next14 app router
3 participants
@kl-nevermore @melloware @yigitfindikli