-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat #5246: add styleContainer option for PrimeReactContext #5566
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Can you check the code base there are other places where styles are added using DomHandler.createInlineStyle() and removeInlineStyle() which I assume would have the same problem? |
@melloware ah nice catch.
For |
Yep definitely pass a second param! |
Also don't forget to update the docs example here: https://primereact.org/configuration/ |
Sorry I've been sick these days. Will get back to this once I'm recovered |
@mondaychen you still working on this? |
@melloware Yes I will continue to work on this once I'm back from holiday break. Is there a deadline or is it considered an urgent issue now? |
Awesome. No I was just checking in on you. |
0276a1b
to
e53476d
Compare
@melloware updated DomHandler and added docs |
In the "AppendTo" section it says "By default all popups are append to document body via Portals.", so I used a similar sentence. But should we say "appended" instead? |
Maybe @melloware can help here |
Yes it should be "appended" ! "By default all popups are appended to the document body via Portals. |
@mondaychen let me know when this is ready but it looks good to me! |
e53476d
to
a3c0dac
Compare
Updated the text & it's ready! @melloware |
Fix #5246
Fix #4096
As discussed in https://github.com/orgs/primefaces/discussions/630#discussion-5931944, this is to add
styleContainer
inPrimeReactContext
so that developers can configureuseStyle
to insert into a specific container. This is needed when building the app within a shadow dom.Example use:
To seem it working:
npm install && npm run dev
(Note this is the same as the reproducer in #5246 except use of new option
styleContainer
is added, but I had to make a repo because on stackblitz.com I was not able to point to github in package.json like https://github.com/mondaychen/prime-react-style-container-repro/blob/main/package.json#L13 (git command is unavailable in terminal)Before (Dropdown style broken):
After: