Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support roundingMode for InputNumber #5525

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Support roundingMode for InputNumber #5525

merged 2 commits into from
Dec 11, 2023

Conversation

trandaison
Copy link
Contributor

@trandaison trandaison commented Dec 5, 2023 •
edited by melloware
Loading

Feature Requests

Support roundingMode for the InputNumber component.

https://github.com/orgs/primefaces/discussions/611

Fix #5528

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2023 1:13am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2023 1:13am

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

Please open a GitHub issue on PrimeReact so we can link this ticket to it.

melloware
melloware requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

Nevermind I ported over your discussion to an issue ticket

@trandaison trandaison requested a review from melloware December 6, 2023 02:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@trandaison trandaison mentioned this pull request Dec 8, 2023
Closed
@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@trandaison trandaison requested a review from melloware December 10, 2023 04:00
@melloware
Copy link
Member

Looks like prettier failed can you run npm run format to format your code?

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware merged commit d51be68 into primefaces:master Dec 11, 2023
4 of 5 checks passed
@kl-nevermore kl-nevermore mentioned this pull request Jan 9, 2024
Merged
@melloware melloware mentioned this pull request Jan 9, 2024
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InputNumber: Support roundingMode for the InputNumber
2 participants
@trandaison @melloware