Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Primefaces #5241, AutoComplete: Primitive value 0 does not display correctly #5242

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

akshayaqburst
Copy link
Contributor

@akshayaqburst akshayaqburst commented Nov 5, 2023

Defect Fixes

fix #5241 AutoComplete: Primitive value 0 does not display correctly

Copy link

vercel bot commented Nov 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 6:32am

@@ -159,7 +159,7 @@ export const AutoComplete = React.memo(
};

const formatValue = (value) => {
if (value) {
if (value || value === 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use ObjectUtils.IsNotEmpty(value)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks. @melloware

@melloware melloware merged commit ef81d79 into primefaces:master Nov 6, 2023
3 checks passed
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoComplete: Primitive value 0 does not display correctly
3 participants