fix(input-number): when zero is entered, value displayed isn't expected

[betavs]

From primefaces/primevue#4539

Fix #5234

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primereact	⬜️ Ignored (Inspect)	Visit Preview		Nov 3, 2023 1:38pm

[github-actions]

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

[betavs]

If this solution works, I'll optimize the code again.

[melloware]

@betavs so the only real change is this line?

inputEl.setSelectionRange(selectionEnd + 1, selectionEnd + 1);

to

inputEl.setSelectionRange(selectionEnd, selectionEnd);

???

[betavs]

@betavs so the only real change is this line?

inputEl.setSelectionRange(selectionEnd + 1, selectionEnd + 1);

to

inputEl.setSelectionRange(selectionEnd, selectionEnd);

???

Yes, but I think it can be optimized to

if (['insert', 'delete-back-single', 'delete-range', 'spin'].includes(operation)) {
    inputEl.setSelectionRange(selectionEnd, selectionEnd);
} else if (operation === 'delete-single') {
    inputEl.setSelectionRange(selectionEnd - 1, selectionEnd - 1);
}

[melloware]

OK can you update your PR for your optimization so I can test it.

[github-actions]

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

[melloware]

Tested and looking good to me.