Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for npm link for local development + incremental builds #5230

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

bweis
Copy link
Contributor

@bweis bweis commented Nov 3, 2023

  • Added a few scripts to facilitate using npm link
  • Edited rollup.config.js to allow to a quicker cut down dev build while developing

Very open to suggestions, perhaps a rollup.dev.config.js would be a better alternative than polluting the current one. However, this works and significantly speeds up development to a 3-4 second build cycle.

See #5231 and linked discussion

Fix #5231

- Added a few scripts to facilitate using npm link
- Editted rollup.config.js to allow to a quicker cut down dev build
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 5:00am

Copy link

github-actions bot commented Nov 3, 2023

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@bweis bweis changed the title Added developer.md for setting up development environment Added Support for npm link for local development + incremental builds Nov 3, 2023
@bweis bweis marked this pull request as ready for review November 3, 2023 05:01
Copy link

github-actions bot commented Nov 3, 2023

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added the Component: Documentation Issue or pull request is related to Documentation label Nov 3, 2023
Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic

@melloware
Copy link
Member

I am personally OK with having this in the main rollup.

@melloware melloware merged commit 446260c into primefaces:master Nov 6, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for faster progressive and incremental builds
2 participants