Fix Tree copy by doing a shallow copy of the value

[hugo-vrijswijk]

Fixes #5080

This does a shallow clone of the value, instead of a deep clone. This way data is not modified. The copy is only 1 level deep. In testing, this worked fine. But someone with more knowledge of the code should review and decide if a deeper copy (excluding data) is needed.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primereact	⬜️ Ignored (Inspect)	Visit Preview		Oct 12, 2023 2:55pm

[melloware]

Hmm I am not sure about doing just a shallow copy. I see your issue with the circular reference but aren't you better off modifying your model object being used in the treenode than to make this assumption of 1 level deep?

[hugo-vrijswijk]

I could write a deep clone that leaves the data property alone. That way it's still recursive but would solve my issue and for anyone using non-serializable data. What do you think?
I unfortunately can't easily change my code to only support serializable data.

[melloware]

OK yeah i would do a deep copy without the data attribute as a start.

[melloware]

something like this..

function deepCopyWithoutData(obj) {
  if (obj === null || typeof obj !== 'object') {
    return obj;
  }

  if (Array.isArray(obj)) {
    return obj.map(item => deepCopyWithoutData(item));
  }

  const result = {};
  for (let key in obj) {
    if (key !== 'data') {
      result[key] = deepCopyWithoutData(obj[key]);
    }
  }

  return result;
}

[hugo-vrijswijk]

Thanks, I made a sort of similar implementation that handles some edge-cases. JavaScript is messy 😅

[hugo-vrijswijk]

@melloware Is this PR good to merge like this? I've tested it both in the docs and my own project and it works on both